-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement terraform Resource methods on resourceMetricsEndpointScrapeJob #1812
base: metrics-endpoint
Are you sure you want to change the base?
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
4fffc5a
to
43a37f0
Compare
6fde641
to
a70d7b0
Compare
…erraform-resource-methods
@@ -27,9 +27,6 @@ const ( | |||
|
|||
func NewClient(authToken string, rawURL string, client *http.Client) (*Client, error) { | |||
parsedURL, err := url.Parse(rawURL) | |||
if parsedURL.Scheme != "https" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this check in order to mock with normal httptest server in acceptance tests.
The failing acceptance tests/cloudinstance seems to be from OnCall tests.. https://github.com/grafana/terraform-provider-grafana/actions/runs/11295196530/job/31417373511?pr=1812 |
This implements the methods for a terraform Resource on resourceMetricsEndpointScrapeJob.
Contributes to https://github.com/grafana/cloud-onboarding/issues/7670.